Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not attempt to sort item when it disables packagist #1039

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 14, 2023

This pull request

  • adds tests for composer.json which disables packagist
  • skips item when it disables packagist

Related to ergebnis/composer-normalize#124.

@localheinz localheinz self-assigned this Dec 14, 2023
@localheinz localheinz changed the title Fix: Add tests for disabling packagist Fix: Do not attempt to sort item when it disables packagist Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3141d2c) 97.90% compared to head (574aded) 97.91%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1039   +/-   ##
=========================================
  Coverage     97.90%   97.91%           
- Complexity      194      196    +2     
=========================================
  Files            32       32           
  Lines           813      815    +2     
=========================================
+ Hits            796      798    +2     
  Misses           17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz merged commit 6d42fb8 into main Dec 14, 2023
19 checks passed
@localheinz localheinz deleted the fix/packagist branch December 14, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants